Skip to content

Drop -Yno-stdlib-patches #24477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 3, 2025
Merged

Drop -Yno-stdlib-patches #24477

merged 3 commits into from
Dec 3, 2025
+10 −145

Conversation

@hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented Nov 18, 2025

Now that the old projects don't exist anymore, we can remove the patching system completely.

@hamzaremmal hamzaremmal marked this pull request as ready for review November 18, 2025 20:23
@hamzaremmal hamzaremmal requested a review from a team as a code owner November 18, 2025 20:23
@hamzaremmal
Copy link
Member Author

hamzaremmal commented Nov 19, 2025

Blocked by: sbt/sbt#8376

@hamzaremmal hamzaremmal mentioned this pull request Nov 28, 2025
Merged
@hamzaremmal hamzaremmal added this to the 3.8.0 milestone Nov 28, 2025
@hamzaremmal hamzaremmal added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Nov 28, 2025
hamzaremmal added a commit that referenced this pull request Dec 1, 2025
@hamzaremmal
chore: deprecate the content of the scala.runtime.stdLibPatches pac…
3adf51e 
…kage (#24587)

Since I'm blocked by a bug in #24477, lets at least deprecate the
objects not allow access to them anymore for 3.8.0.
@hamzaremmal hamzaremmal requested a review from Gedochao December 2, 2025 15:49
Gedochao
Gedochao reviewed Dec 3, 2025
View reviewed changes
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

community-build/test/scala/dotty/communitybuild/CommunityBuildTest.scala
@Test def scas = projects.scas.run()
@Test def sconfig = projects.sconfig.run()
@Test def shapeless3 = projects.shapeless3.run()
//@Test def shapeless3 = projects.shapeless3.run()
Copy link
Contributor

@Gedochao Gedochao Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hamzaremmal can we have a ticket to track this?

@hamzaremmal hamzaremmal merged commit 320e5ea into scala:main Dec 3, 2025
46 checks passed
@hamzaremmal hamzaremmal deleted the drop-stdlib-patches branch December 3, 2025 10:23
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Dec 3, 2025
@WojciechMazur WojciechMazur mentioned this pull request Dec 3, 2025
Merged
WojciechMazur added a commit that referenced this pull request Dec 3, 2025
@WojciechMazur
Backport "Drop -Yno-stdlib-patches" to 3.8.0 (#24642)
410795a 
Backports #24477 to the 3.8.0-RC3.

PR submitted by the release tooling.
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gedochao Gedochao Gedochao approved these changes

@WojciechMazur WojciechMazur Awaiting requested review from WojciechMazur

Assignees

@Gedochao Gedochao

@WojciechMazur WojciechMazur

Labels

backport:done This PR was successfully backported.

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@hamzaremmal @Gedochao @WojciechMazur